-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to "align_multiple_visits" and "align_sparse_fields" notebooks #266
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Would it be more straightforward for CI testing to have these two notebooks in separate PRs? |
@mackjenn good point, I'm not sure. @haticekaratay what would you prefer? happy to make the switch if desired. |
hi @haticekaratay, we (INS) are trying to get this work closed out ASAP. can you check what the new "bandit" error messages are about? also, can we remove align_sparse_fields from this pull request, since that is already passed in another pull request? thank you! |
also now there is an issue where it complains the "image" directory already exists, when it doesn't until its made as part of the relevant cell? I'm at a total loss at this point, the CI errors do not make sense and are effectively impossible for me to debug. |
This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.