Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CRDS to STIS notebooks requirements #185

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Conversation

sean-lockwood
Copy link
Member

Modifying requirements files for STIS cross-correlation.ipynb and calstis_2d_ccd.ipynb to add the CRDS package. Hopefully this will allow calstis to access reference files when reprocessing data.

These are pre-existing notebooks.

@sean-lockwood
Copy link
Member Author

sean-lockwood commented Feb 1, 2024

@haticekaratay -
How can we get this to run the regression suite on the two notebooks?

cc: @Jackie-Brown

@sean-lockwood
Copy link
Member Author

sean-lockwood commented Feb 1, 2024

@haticekaratay -

Looks like the requirements.txt and pre-requirements.sh files do not trigger the CI:

https://github.com/spacetelescope/hst_notebooks/blob/main/.github/workflows/ci_runner.yml#L15

@sean-lockwood sean-lockwood added bugfix Fixed something that wasn't working STIS Space Telescope Imaging Spectrograph labels Feb 1, 2024
@haticekaratay
Copy link
Collaborator

@haticekaratay -

Looks like the requirements.txt and pre-requirements.sh files do not trigger the CI:

https://github.com/spacetelescope/hst_notebooks/blob/main/.github/workflows/ci_runner.yml#L15

Thanks, @sean-lockwood, for working on this. It's triggered by an edit to the notebook due to the way the CI is set up. I suggest making a small change to the notebook.

@sean-lockwood
Copy link
Member Author

@Jackie-Brown -
Would you mind making the minor changes to the two notebooks, at your convenience?

@haticekaratay haticekaratay self-requested a review February 1, 2024 20:38
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Jackie-Brown
Copy link
Contributor

@sean-lockwood made some minor text changes and checks are now running

Copy link
Collaborator

@haticekaratay haticekaratay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, both @sean-lockwood and @Jackie-Brown, for working on these notebooks.

@haticekaratay haticekaratay merged commit ac464e5 into main Feb 1, 2024
7 checks passed
@haticekaratay haticekaratay deleted the jbrown-add-crds-stis branch February 1, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixed something that wasn't working STIS Space Telescope Imaging Spectrograph
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants