-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WFC3 notebook 'flux_conversion_tool.ipynb' #104
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Update flux conversion notebook
@FDauphin, I removed the unrelated notebooks from the diff so that only the flux_conversion notebook changes are visible. I also resolved the conflicts to make it easier for everyone to work on the notebook. This notebook will be next in the queue for a technical review. |
PEP8 fix for flux conversion notebook
@haticekaratay This notebook has passed all checks and is ready for review 👍🏾 |
Thank you for your work. I've reviewed the notebook and noticed it shares several commonalities and issues with the earlier 'filter_transformation' notebook, as mentioned in my previous review, more descriptive variable naming would significantly enhance clarity. I also recommend f-strings for string formatting, as they offer a more concise and readable alternative to the .format method. |
@st-apidgeon putting this on your radar in case you missed it 👍🏾 |
Variable name and style changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the notebook.
Relevant Tickets
This notebook checklist has been made available to us by the Notebooks For All team.
Its purpose is to serve as a guide for both the notebook author and the technical reviewer highlighting critical aspects to consider when striving to develop an accessible and effective notebook.
The First Cell
<h1>
or# in markdown
).1., 2.,
etc. in Markdown).The Rest of the Cells
#
in Markdown) used in the notebook.Text
Code
Images
All images (jpg, png, svgs) have an image description. This could be
alt
property)alt
attribute with no value)Any text present in images exists in a text form outside of the image (this can be alt text, captions, or surrounding text.)
Visualizations
All visualizations have an image description. Review the previous section, Images, for more information on how to add it.
Visualization descriptions include
All visualizations and their parts have enough color contrast (color contrast checker) to be legible. Remember that transparent colors have lower contrast than their opaque versions.
All visualizations convey information with more visual cues than color coding. Use text labels, patterns, or icons alongside color to achieve this.
All visualizations have an additional way for notebook readers to access the information. Linking to the original data, including a table of the data in the same notebook, or sonifying the plot are all options.