Move examples from conftest to an examples module #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #521 +/- ##
==========================================
+ Coverage 87.28% 87.41% +0.13%
==========================================
Files 22 22
Lines 3821 3869 +48
==========================================
+ Hits 3335 3382 +47
- Misses 486 487 +1 ☔ View full report in Codecov by Sentry. |
WilliamJamieson
commented
Oct 30, 2024
Comment on lines
+471
to
+473
| # pipeline = [('detector', wcs_forward), (comp_frm, None)] | ||
| w = wcs.WCS(forward_transform=wcs_forward, output_frame=comp_frm, | ||
| input_frame=detector_frame) |
There was a problem hiding this comment.
Should this be updated to
Suggested change
| # pipeline = [('detector', wcs_forward), (comp_frm, None)] | |
| w = wcs.WCS(forward_transform=wcs_forward, output_frame=comp_frm, | |
| input_frame=detector_frame) | |
| pipeline = [(detector_frame, wcs_forward), (comp_frm, None)] | |
| w = wcs.WCS(pipeline) |
There was a problem hiding this comment.
I think the above is still an allowed way to initialize a WCS object. Let's keep it as is.
nden
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to interactively work with GWCS using pre-made models.