Add on spring cleaning #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a `BaseCoordinateFrame` class, definining the minimal API for a coordinate frame with descriptive docstrings. This is done mainly as an exercise to easily review and document the API. Also add significant docstring to the module describing how and why coordinate frames work.
The goal of this refactoring is to be able to remove `Frame.coordinates` and `Frame.coordinate_to_quantity` and rely on the Astropy WCSAPI machinery to do those conversions.
coordinates() and coordinate_to_quantity() are replaced by APE 14 methods
This highlights some API changes here.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
==========================================
- Coverage 87.25% 87.05% -0.20%
==========================================
Files 22 22
Lines 3814 3717 -97
==========================================
- Hits 3328 3236 -92
+ Misses 486 481 -5 ☔ View full report in Codecov by Sentry. |
Cadair
reviewed
Sep 25, 2024
|
|
||
| .. code-block:: python | ||
|
|
||
| [SpectralCoord(axes_order=(1,)), CelestialCoord(axes_order=(2, 0))] |
There was a problem hiding this comment.
Suggested change
| [SpectralCoord(axes_order=(1,)), CelestialCoord(axes_order=(2, 0))] | |
| [SpectralFrame(axes_order=(1,)), CelestialFrame(axes_order=(2, 0))] |
|
I just discovered another bug that's fixed by this, so I guess it's time for me to resurrect it again |
|
I have merged this back into #457 so I can keep pushing there. This can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds on #457. It includes all changes by @Cadair in that PR.
All, but the SlicedWCS, tests pass locally.
@Cadair @perrygreenfield