-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor axis_physical_types
#459
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #459 +/- ##
==========================================
- Coverage 87.25% 86.90% -0.35%
==========================================
Files 23 23
Lines 3820 3857 +37
==========================================
+ Hits 3333 3352 +19
- Misses 487 505 +18
☔ View full report in Codecov by Sentry. |
These changes look good to me overall. It's unclear what the return type should be. In the FITS implementation it's defined as The new |
This moves the logic for the default physical types into the subclasses rather than the base class.
I would say tuple rather than a list is perfectly fine, iterable is iterable. 🤷 |
I have pulled the |
axis_physical_types
and add PixelFrame
axis_physical_types
Failure is unrelated |
@Cadair I'm trying to sort out the jwst regression tests and once done will merge this. |
This is the second part of #457
The main work here is refactoring the logic of deciding the default coordinate frames from the base class into subclasses. Also add a
PixelFrame
which supports multiple dimensions. I haven't done anything withFrame2D
here, but imo this is a complete replacement for it?