Fix dependencies. Simplify tests. Reduce data file size. Add a new unit test. #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
astropy
as a dependency but keeps it as a dependency only for testing.pytest.mark.parametrize
to combine multiple tests into a single one.input3
andinput1
. the later was renamed toj8bt06nyq_sip_flt.fits
).j8bt06nyq_sip_flt.fits
was used only to supply the WCS, I have removed SCI/ERR/DQ data arrays to reduce the size of the package. Something similar was done with other files such asreference_blot_*.fits
andreference_{kernel_name}_*.fits
since only SCI images was used in testing: I kept only the SCI extension and removed WHT and CTX extensions.j8bt06nyq_flt.fits
and checks the result (it checks SCI/WHT and CTX extensions) againstreference_turbo_image.fits
andreference_square_image.fits
. These reference files were in this repository since it was created but they were never used before. In order to make the test work, image intensity (scale
parameter) had to be set to the ratio between the output pixel scale and input pixel scale which appear to be different from the default value of 1. This will need to be investigated further and maybe "OKify" current results in order to get rid of setting thisscale
argument. Another limitation is that this test works for the inner region of the image. At the edges (the slanted edges) of the image, the edge of the input image forms a staircase. Some pixels along the border are different. Most probably this is a result of a change in how overlaps (between input and output) are computed and rasterized. I think this is a minor issue.