Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/data-release-contexts #1076

Merged
merged 41 commits into from
Sep 25, 2024
Merged

feature/data-release-contexts #1076

merged 41 commits into from
Sep 25, 2024

Conversation

alphasentaurii
Copy link
Collaborator

@alphasentaurii alphasentaurii commented Sep 25, 2024

Resolves CCD-1500

Closes #

Backwards-incompatible changes:

  • Default context changed from "operational" to "latest".
    -client.api.get_default_context by default returns build context for JWST as determined by locally installed calibration software version. This can be overridden if CRDS_CONTEXT environment variable is explicitly set by user, or the optional arg state is set to a specific value, e.g. "latest", "build", or "edit".

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
news fragment change types...
  • changes/<PR#>.hst.rst: HST reference files
  • changes/<PR#>.jwst.rst: JWST reference files
  • changes/<PR#>.roman.rst: Roman reference files
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.testing.rst: change to tests or test automation
  • changes/<PR#>.general.rst: infrastructure or miscellaneous change

alphasentaurii and others added 30 commits July 24, 2024 18:23
* translate latest to operational context

* incl state in server call to get_default_context

* update changelog
* revert back to v1 zendesk action

* replace with latest

* handle latest and build as context, flexibility for allowing operational

* better checks for latest,build in jsonapi related calls

* typo - should be =

* fix typo
* revert back to v1 zendesk action

* if no cal software installed, default to latest
* translate latest to operational context

* incl state in server call to get_default_context

* update changelog
* revert back to v1 zendesk action

* replace with latest

* handle latest and build as context, flexibility for allowing operational

* better checks for latest,build in jsonapi related calls

* typo - should be =

* fix typo
@alphasentaurii alphasentaurii requested a review from a team as a code owner September 25, 2024 16:36
@alphasentaurii alphasentaurii changed the title Data release contexts feature/data-release-contexts Sep 25, 2024
Copy link
Collaborator

@stscieisenhamer stscieisenhamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass and code looks good. LGMT

@hbrown-ST
Copy link
Collaborator

LGTM as well, yay to tests passing

@alphasentaurii alphasentaurii merged commit f76c37c into master Sep 25, 2024
10 of 11 checks passed
@alphasentaurii alphasentaurii deleted the data-release-contexts branch September 25, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants