Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCSB-174] move DMS requirement <-> test correlations from @metrics_logger decorators to test/dms_requirement_tests.json #1064

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Sep 9, 2024

Resolves SCSB-174

consolidates all test requirement correlations into test/dms_requirement_tests.json, obviating the need to insert log messages at test execution time with metrics_logger

This PR (and its sister PRs spacetelescope/romancal#1399 and spacetelescope/romanisim#146) blocks https://grit.stsci.edu/dmd/roman-metrics/-/merge_requests/21

@zacharyburnett zacharyburnett self-assigned this Sep 9, 2024
@zacharyburnett zacharyburnett changed the title consolidate test requirements into test_requirements.json [SCSB-174] replace metrics_logger with test_requirements.json file Sep 9, 2024
@zacharyburnett zacharyburnett marked this pull request as ready for review September 10, 2024 15:08
@zacharyburnett zacharyburnett requested a review from a team as a code owner September 10, 2024 15:08
@zacharyburnett zacharyburnett marked this pull request as draft September 10, 2024 15:08
@zacharyburnett zacharyburnett marked this pull request as ready for review September 11, 2024 15:17
@zacharyburnett zacharyburnett changed the title [SCSB-174] replace metrics_logger with test_requirements.json file [SCSB-174] move DMS requirement correlations with tests from @metrics_logger to decorators to test/dms_requirement_tests.json Sep 12, 2024
@zacharyburnett zacharyburnett changed the title [SCSB-174] move DMS requirement correlations with tests from @metrics_logger to decorators to test/dms_requirement_tests.json [SCSB-174] move DMS requirement test correlations from @metrics_logger decorators to test/dms_requirement_tests.json Sep 12, 2024
@zacharyburnett zacharyburnett changed the title [SCSB-174] move DMS requirement test correlations from @metrics_logger decorators to test/dms_requirement_tests.json [SCSB-174] move DMS requirement <-> test correlations from @metrics_logger decorators to test/dms_requirement_tests.json Sep 12, 2024
Copy link

@jglorioso-stsci jglorioso-stsci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified contents of dms_requirement_tests.json to the test files. Looks good!

@zacharyburnett zacharyburnett merged commit 73830bd into spacetelescope:master Sep 13, 2024
10 checks passed
@zacharyburnett zacharyburnett deleted the scsb174 branch September 13, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants