-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCSB-174] move DMS requirement <-> test correlations from @metrics_logger
decorators to test/dms_requirement_tests.json
#1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zacharyburnett
force-pushed
the
scsb174
branch
from
September 9, 2024 18:12
0f7c103
to
4d876f7
Compare
zacharyburnett
changed the title
consolidate test requirements into
[SCSB-174] replace Sep 9, 2024
test_requirements.json
metrics_logger
with test_requirements.json
file
zacharyburnett
force-pushed
the
scsb174
branch
from
September 10, 2024 15:08
4d876f7
to
a417937
Compare
This was referenced Sep 11, 2024
zacharyburnett
force-pushed
the
scsb174
branch
from
September 12, 2024 14:26
eaf8119
to
2e266df
Compare
zacharyburnett
changed the title
[SCSB-174] replace
[SCSB-174] move DMS requirement correlations with tests from Sep 12, 2024
metrics_logger
with test_requirements.json
file@metrics_logger
to decorators to test/dms_requirement_tests.json
zacharyburnett
changed the title
[SCSB-174] move DMS requirement correlations with tests from
[SCSB-174] move DMS requirement test correlations from Sep 12, 2024
@metrics_logger
to decorators to test/dms_requirement_tests.json
@metrics_logger
decorators to test/dms_requirement_tests.json
zacharyburnett
changed the title
[SCSB-174] move DMS requirement test correlations from
[SCSB-174] move DMS requirement <-> test correlations from Sep 12, 2024
@metrics_logger
decorators to test/dms_requirement_tests.json
@metrics_logger
decorators to test/dms_requirement_tests.json
zacharyburnett
force-pushed
the
scsb174
branch
from
September 12, 2024 15:46
2e266df
to
dcb3f3e
Compare
zacharyburnett
force-pushed
the
scsb174
branch
from
September 12, 2024 15:53
dcb3f3e
to
f78219b
Compare
stscieisenhamer
approved these changes
Sep 12, 2024
jglorioso-stsci
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified contents of dms_requirement_tests.json to the test files. Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SCSB-174
consolidates all test requirement correlations into
test/dms_requirement_tests.json
, obviating the need to insert log messages at test execution time withmetrics_logger
This PR (and its sister PRs spacetelescope/romancal#1399 and spacetelescope/romanisim#146) blocks https://grit.stsci.edu/dmd/roman-metrics/-/merge_requests/21