-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
roman/decorate-old-tests #1034
Merged
alphasentaurii
merged 22 commits into
spacetelescope:master
from
alphasentaurii:roman-metrics-tagging
Apr 18, 2024
Merged
roman/decorate-old-tests #1034
alphasentaurii
merged 22 commits into
spacetelescope:master
from
alphasentaurii:roman-metrics-tagging
Apr 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdf tags to use asterisk in roman certify
zacharyburnett
approved these changes
Apr 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CCD-1438:
hst_default_cache_state
,jwst_default_cache_state
: these use the newdefault_cache
fixture to point directly tocrds-cache-default-test
, in addition to explicitly setting mode='auto', url, and observatory. Some tests were failing because they relied on thecrds_shared_group_cache
fixture which returns the CRDS built-inconfig.get_crds_path()
. The path returned is not always what the test expects it to be and in many cases was incorrect (e.g.crds-cache-test
or 'data/'.Note: ultimately we may want to move remaining tests away from using the 'crds_shared_group_cache' altogether - I elected not to do that for now because the majority of tests using it were fine and I'd rather not break something that didn't need fixing.
Decorated tests with observatory-based markers according to the test configuration and/or data being used in the test. For tests that don't use an observatory-based test configuration, the marker is "multimission". The primary intention here is to aid in troubleshooting setup/teardown problems. E.g. a test with an "hst" marker might be a mission-agnostic feature of CRDS, but it explicitly relies on the hst server, hst test data, etc.
added CRDS_PATH and CRDS_TESTING_CACHE to github actions ci.yml env
CCD-1434:
Added metrics_logger decorator to Roman tests delivered with older builds (test_certify.py)