Add BMC deformable mirror class #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehpor when you have a moment, let me know what you think. |
ivalaginja
force-pushed
the
feature/dm_base_class
branch
from
f86b864
to
bcc5ccd
Compare
ivalaginja
force-pushed
the
feature/dm_base_iva
branch
from
0c42b0f
to
a0512bf
Compare
|
Merging to keep a single PR open for this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delta-PR for the DM base class, merges into #156.
Adds a base class for the BMC that inherits from the DeformableMirrorService service. It implements the actual hardware service for BMC DMs, using the base class.
I put the voltage discretization in the base class since that is something that applies to any DM. I do this using a property so it can be accessed by either of the two classes (set in the BMC service, handled in the base service). The discretization for the surface that gets sent to the simulator is handled in the simulated service directly.