Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update Solo and SDO data downloaders #3

Merged
merged 18 commits into from
Dec 4, 2023
Merged

Conversation

nkasmanoff
Copy link
Contributor

No description provided.

Copy link
Member

@jejjohnson jejjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nkasmanoff
Copy link
Contributor Author

@jejjohnson updated the editors docs. Full disclosure, a lot of these updates were using GitHub copilot, I just told it where to go and confirmed it looked right.

If the files in editors.py look acceptable along with the changes I made to the first few notebooks, we can merge this.

Unsure if you want to look it over again so I'll hold off until doing a merge!

Copy link
Member

@jejjohnson jejjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good from my end! Merge when you're ready!

@jejjohnson jejjohnson merged commit 93370ea into main Dec 4, 2023
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants