POS data verification #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 97.43% 97.56% +0.12%
==========================================
Files 12 13 +1
Lines 1481 1601 +120
==========================================
+ Hits 1443 1562 +119
- Misses 38 39 +1
|
fasmat
reviewed
Jul 19, 2023
Comment on lines
+83
to
+90
| CpuInitializer::new(scrypt_params) | ||
| .initialize_to( | ||
| &mut expected_label.as_mut_slice(), | ||
| &commitment, | ||
| label_index..label_index + 1, | ||
| None, | ||
| ) | ||
| .map_err(|e| VerificationError::InitError(format!("{e:?}")))?; |
There was a problem hiding this comment.
Can this instance be re-used? Creating a new instance of CpuInitializer for every label that is verified seems wasteful.
There was a problem hiding this comment.
It's free:
Lines 96 to 100 in d70db43
There was a problem hiding this comment.
doesn't this still need to allocate the object and free it again on every iteration?
There was a problem hiding this comment.
No. It's on the stack, so nothing needs to be allocated. It will be completely optimized away.
fasmat
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to spacemeshos/post#180
Add a way to verify a fraction of labels of initialized POS.