Introduce events about communication with PoET #382
+884
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
fasmat
reviewed
Oct 10, 2024
jellonek
force-pushed
the
events/poet
branch
2 times, most recently
from
28762a7
to
2d6255b
Compare
fasmat
reviewed
Oct 14, 2024
| @@ -131,6 +156,25 @@ message EventMalfeasance { | |||
|
|
|||
| message EventStreamRequest {} | |||
|
|
|||
| message EventRegisteredInPoet { | |||
| string url = 1; | |||
| bytes challenge = 2; | |||
There was a problem hiding this comment.
I think this doesn't need to be part of the event. It's the hash of the header of the next ATX (not the hash/ID of the ATX), so not really useful to a user. However I think this event should include a bytes smesher field to know which identity was registered in PoET.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of spacemeshos/go-spacemesh#5565