yaml AudioParams are often ignored

[ElectroJr]

In many cases, systems that play sound ignore the audio options associated with a SoundSpecifier. I.e., they don't use the SoundSpecifier.Params field. Instead they often just bulldoze it with the default options. This should be fixed, so that sound options can be consistently specified in yaml.

E.g., stuff like

Audio.PlayPvs(cartridge.EjectSound, entity, AudioParams.Default.WithVariation(SharedContentAudioSystem.DefaultVariation).WithVolume(-1f));

needs to be replaced with something like

var @params = cartridge.EjectSound?.Params ?? AudioParams.Default;
@params = @params.AddVolume(-1f).WithVariation(SharedContentAudioSystem.DefaultVariation);
Audio.PlayPvs(cartridge.EjectSound, entity, @params);

Here are some the common mistakes/issues that need to be fixed:

• Most uses of AudioParams.WithVolume() should probably be replaced with AudioParams.AddVolume()
• AudioHelpers.WithVariation() needs to be removed.
  • There is now a AudioParams.Variation field that should be set. Though again, in many cases that should be set in yaml not in C#, as that just bulldozes the yaml value.
  • Maybe there should be a AddVariation() method, akin to AddVolume()?
• Many sounds just don't use the sound specifier's options.
  • These are pretty easy to find by just looking for where AudioParams.Default is used.
• Some systems convert sound specifiers into strings before using PlaySound.
  • Most of the time this is probably unnecessary, and they probably also forget to check the specifier's audio parameters.
  • These can often be found by looking at uses of AudioSystem.GetSound()
• Sometimes audio parameters are specified inconsistently.
  • These are likely holdovers from before SoundSpecifier.Params was added and need to be updated.
  • E.g., the PlaySound construction action has its own AudioParams instead of just using the SoundSpecifier's.