Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidebook reagents could do with some reorganisation. #34266

Open
Alpaccalypse opened this issue Jan 7, 2025 · 3 comments · May be fixed by #34311
Open

Guidebook reagents could do with some reorganisation. #34266

Alpaccalypse opened this issue Jan 7, 2025 · 3 comments · May be fixed by #34311
Labels
A: Guidebook Area: Ingame guidebook, content or technical implementation DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Cleanup Type: Code clean-up, without being a full refactor or feature

Comments

@Alpaccalypse
Copy link
Contributor

Alpaccalypse commented Jan 7, 2025

Description

The main offender is the "Others" category, many of the reagents listed there fit into existing categories or could be moved to more informative new categories. i.e Some elements are there instead of in "Elements", gases could be added to a new gases category, pretty sure there are quite a few other reagents that could be moved, but not looked extensively yet.

Reproduction
Look at the "Others" category for reagents in the guidebook. It is very large and doesn't have any recognizable order to it.

Additional context
I think "Others" might be the largest sub-category list right now, which seems a bit off. Also the formatting in the game files and for the guidebook summary doesn't match the general convention.

@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Jan 7, 2025
@slarticodefast
Copy link
Member

Yep, same for the files they are in. The yaml files for the reactions mirror the files for the reagents, but they are not consistently sorted into their categories.

@Alpaccalypse
Copy link
Contributor Author

I've been looking at reactions and happened to stumble upon issue #27543. I was hoping I could just do some simple .yml editing to get this working, but it is starting to look a bit more complicated than that. I'm probably going to start working on a PR to address the issue posted here, but with a bit of luck I might be able to incorporate the reactions category suggested in that related issue.

@Alpaccalypse
Copy link
Contributor Author

Nearly finished a PR for this. Just holding off to go over the files and do any reformating/rearanging internally, while they are being edited anyway.

@lzk228 lzk228 added P3: Standard Priority: Default priority for repository items. T: Cleanup Type: Code clean-up, without being a full refactor or feature DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: Guidebook Area: Ingame guidebook, content or technical implementation S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Jan 8, 2025
@Alpaccalypse Alpaccalypse linked a pull request Jan 9, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: Guidebook Area: Ingame guidebook, content or technical implementation DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants