Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add normal parents to our coats 🧰 #2251

Merged
merged 4 commits into from
Jun 13, 2024
Merged

add normal parents to our coats 🧰 #2251

merged 4 commits into from
Jun 13, 2024

Conversation

icekot8
Copy link
Contributor

@icekot8 icekot8 commented Jun 13, 2024 •
edited
Loading

Описание PR

я открыл Resources/Prototypes/Corvax/Entities/Clothing/OuterClothing/coats.yml, увидел 3 тупых накопившихся наследования, и онормалил их, чтобы они не несли кринжом :trollface:
а, ещё, из-за этих умнейших наследований, на всех респрайтах/альт айтемах корвакса, пренадлежащих СБ, не может быть повешено оружие в сьюитслот, когда на их изначальную версию - можно. cringe 🧰.
Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

no cl no fun 🔍

@icekot8 icekot8 requested a review from Morb0 as a code owner June 13, 2024 19:54
@github-actions github-actions bot added Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged labels Jun 13, 2024
@lapatison
Copy link
Contributor

Оф-..
А, ну да

lzk228
lzk228 requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

для ClothingOuterCoatHoSGreatcoat спрайт перенеси в папку корвакс
из этих троих убери армор, чтобы унаследовалось от родителей

Resources/Prototypes/Corvax/Entities/Clothing/OuterClothing/coats.yml Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design label Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 13, 2024 •
edited
Loading

RSI Diff Bot; head commit 237a4e9 merging into af33e9d
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:
Edit: diff updated after 237a4e9

@icekot8 icekot8 requested a review from lzk228 June 13, 2024 20:26
@lzk228 lzk228 merged commit 3c6c45c into space-syndicate:master Jun 13, 2024
15 checks passed
@icekot8 icekot8 deleted the parents branch June 13, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzk228 lzk228 lzk228 approved these changes

@Morb0 Morb0 Awaiting requested review from Morb0 Morb0 is a code owner

Assignees
No one assigned
Labels
Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icekot8 @lapatison @lzk228