Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Musician Jumpskirt #2231

Closed
wants to merge 4 commits into from
Closed

Musician Jumpskirt #2231

wants to merge 4 commits into from

Conversation

meowstushka
Copy link
Contributor

Описание PR

Добавляет в игру платье из карпокожи, ибо по моему скромному мнению женским персонажам играющих на музыкантах его не хватает. Платье также добавлено в меню начального снаряжения и доступно для выбора.

Медиа

image
image
image

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрела все свои изменения и багов в них не нашла.
  • Я запускала локальный сервер со своими изменениями и всё протестировала.
  • Я добавила скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения
🆑 meowstushka

  • add: Добавлена юбка-комбинезон музыканту.

@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation labels Jun 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 10, 2024 •
edited
Loading

RSI Diff Bot; head commit ca4a7d0 merging into d01c1cc
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Corvax/Clothing/Uniforms/Jumpskirt/musician.rsi

State Old New Status
equipped-INNERCLOTHING-monkey Added
equipped-INNERCLOTHING-reptilian Added
equipped-INNERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Edit: diff updated after ca4a7d0

@lzk228
Copy link
Collaborator

lzk228 commented Jun 10, 2024

оффам

@lzk228
Copy link
Collaborator

lzk228 commented Jun 10, 2024

а я же ещё так могу :trollface:

@lzk228 lzk228 closed this Jun 10, 2024
@lzk228
Copy link
Collaborator

lzk228 commented Jun 10, 2024

даже больше скажу, такой пр уже есть, со спрайтом подходящим оффам, потом просто респрайт сделаешь у нас
space-wizards/space-station-14#26042

@DreamlyJack
Copy link
Contributor

Такое уже мы с Артом проворачивали, увы, сказали что пока нет дела до этого

@meowstushka
Copy link
Contributor Author

даже больше скажу, такой пр уже есть, со спрайтом подходящим оффам, потом просто респрайт сделаешь у нас space-wizards/space-station-14#26042

Ну получается время открывать? Респрайт все дела.

@lzk228 lzk228 reopened this Jun 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict PR have unsolved merge conflicts label Jun 20, 2024
@meowstushka
Copy link
Contributor Author

Время фиксить (:

@lzk228
Copy link
Collaborator

lzk228 commented Jun 20, 2024

время ждать апстрима :trollface:

@lzk228
Copy link
Collaborator

lzk228 commented Jun 21, 2024

@meowstushka фикси

@meowstushka
Copy link
Contributor Author

@meowstushka фикси

В процессе

@meowstushka meowstushka deleted the Musician-Jumpskirt branch June 21, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ficcialfaint ficcialfaint Awaiting requested review from ficcialfaint ficcialfaint is a code owner

@Morb0 Morb0 Awaiting requested review from Morb0 Morb0 is a code owner

Assignees
No one assigned
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Merge Conflict PR have unsolved merge conflicts Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@meowstushka @lzk228 @DreamlyJack