Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Locale Guidebook for Revolution. #1985

Merged
merged 12 commits into from
Mar 26, 2024
Merged

Locale Guidebook for Revolution. #1985

merged 12 commits into from
Mar 26, 2024

Conversation

CatBackGround
Copy link
Contributor

@CatBackGround CatBackGround commented Mar 22, 2024 •
edited
Loading

Описание PR

Я тут решил помочь с переводом гайдбука, так что вот. Держите локализацию для Революции. А ещё этот PR является частью данной задачи #1642.

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑 Cat

  • tweak: Теперь есть локализация на Революцию!

@CatBackGround CatBackGround requested a review from Morb0 as a code owner March 22, 2024 14:21
@github-actions github-actions bot added Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged labels Mar 22, 2024
@lapatison
Copy link
Contributor

И не Глава\ы революционеров, а Глава\ы революции

CatBackGround and others added 7 commits March 23, 2024 10:20
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
e1f2f2d 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
38c200c 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
9e439c4 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
bb67855 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
a4db536 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
db274b3 
Co-authored-by: lzk <[email protected]>
@CatBackGround @lzk228
Update Resources/ServerInfo/Guidebook/Antagonist/Revolutionaries.xml
1f2792a 
Co-authored-by: lzk <[email protected]>
@CatBackGround
Copy link
Contributor Author

Я вас услышал, и осознал что мой перевод был на троечку. Все правки приняты.

@CatBackGround CatBackGround requested a review from lzk228 March 23, 2024 05:23
lzk228
lzk228 approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@lzk228 lzk228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

мне норм

@CatBackGround CatBackGround requested a review from lapatison March 24, 2024 13:18
@Morb0 Morb0 merged commit d3caf7d into space-syndicate:master Mar 26, 2024
3 checks passed
@CatBackGround CatBackGround deleted the guidebook-translate branch March 28, 2024 07:58
@TheArturZh TheArturZh mentioned this pull request Apr 28, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzk228 lzk228 lzk228 approved these changes

@Morb0 Morb0 Awaiting requested review from Morb0 Morb0 is a code owner

@lapatison lapatison Awaiting requested review from lapatison

Assignees
No one assigned
Labels
Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CatBackGround @lapatison @lzk228 @Morb0