Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync #1949

Merged
merged 37 commits into from
Mar 11, 2024
Merged

Upstream sync #1949

merged 37 commits into from
Mar 11, 2024

Conversation

Morb0
Copy link
Member

@Morb0 Morb0 commented Mar 11, 2024

Описание PR

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

Ko4ergaPunk and others added 30 commits March 9, 2024 02:48
* fix

* Remove stripes

* empty
made a new nukie song lel.
* Remove unecessary prototypes

* Put unecessary prototypes in migration.yml
- every category of type "cargoProduct" was edited to "cargoproduct-category-name-{categoryName}"
- file "cargoproduct-categories.ftl" was added to english localization to localize categories of cargoProduct
- CargoConsoleMenu.xaml.cs got tweaks which prevent issues with strings comparisons
* Remove unnecessary datafield names, syringes with stuff in them start in inject mode

* No trash tag

* Remove ViewVariables since DataField has them implicitly

* Revert "No trash tag"

This reverts commit 2c42172653d2cc70d58bd5bedf61a880b939bf20.

* Get rid of tags entirely for PrefilledSyringes

---------

Co-authored-by: Plykiya <[email protected]>
* Add a toggle for progress bar colors

* yeah this thing

* PJB review

* optimization
added winddown to drug effect
* Small obsolete Logger cleanup

* Fixed three EntitySystem logs that weren't doing it right.
Thinks there's obstacles when there isn't.
* Fix game.role_timers not effecting the antag menu

* Yeah i guess i should
* Prevents FloorOcclusion from breaking rendering

* Minor change
The EmergencyAccess bool on the AirlockComponent would not get synced to the client
* Fix shield absorbing asphyxiation damage

Shields will no longer reduce damage on their user that they themselves
can't absorb.

* Update Content.Shared/Blocking/BlockingSystem.User.cs

---------

Co-authored-by: metalgearsloth <[email protected]>
* Add files via upload

* Update rubber_stamp.yml
- HideLabel just means it won't have its name / button drawn whereas Hide will block it completely.
* guidebook pages defined

* species info button in character profile editor

* if current species has no guidebook page then open the parent page

* skrek

* destroying evidence of secret vox plot

* icon size adjustment, no icon if guidebook page for species does not exist

* finished pages

* additional info

* weh
* Security hud shows icon based on criminal record status

* Criminal status now linked to name instead of identity

* parole loc

* Test fix

* review changes

* Check station records instead of storing names on criminal record consoles.

* cleanup

* more cleanup

* review changes

* change outdated comments

* rename

* review changes

* remove event subscription

* replaced event with trycomp

* default value
PJBot and others added 7 commits March 11, 2024 03:13
* Revert "detective patch (#24739)"

This reverts commit 8ef69ff.

* Revert "Detectives gain independency (#23114)"

This reverts commit 807f5fa.
buff hydroponics crate

Co-authored-by: deltanedas <@deltanedas:kde.org>
# Conflicts:
#	Content.Shared/Humanoid/Prototypes/SpeciesPrototype.cs
#	Resources/Prototypes/Roles/Jobs/Security/detective.yml
#	Resources/Prototypes/SoundCollections/NukeMusic.yml
@Morb0 Morb0 requested a review from ficcialfaint as a code owner March 11, 2024 05:51
@github-actions github-actions bot added Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged labels Mar 11, 2024
Copy link
Contributor

RSI Diff Bot; head commit f5e8409 merging into f60a0a2
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Misc/job_icons.rsi

State Old New Status
Detective Modified

Resources/Textures/Objects/Misc/id_cards.rsi

State Old New Status
iddetective Modified

Resources/Textures/Objects/Misc/stamps.rsi

State Old New Status
stamp-detective Modified

Resources/Textures/Tiles/Planet/Chasms/basalt_chasm.rsi

State Old New Status
chasm Modified
chasm1 Modified
chasm3 Modified
chasm4 Modified
chasm6 Modified

Resources/Textures/Tiles/Planet/Chasms/chromite_chasm.rsi

State Old New Status
chasm Modified
chasm1 Modified
chasm3 Modified
chasm4 Modified
chasm6 Modified

Resources/Textures/Tiles/Planet/Chasms/desert_chasm.rsi

State Old New Status
chasm Modified
chasm1 Modified
chasm3 Modified
chasm4 Modified
chasm6 Modified

Resources/Textures/Tiles/Planet/Chasms/snow_chasm.rsi

State Old New Status
chasm Modified
chasm1 Modified
chasm3 Modified
chasm4 Modified
chasm6 Modified

Resources/Textures/Interface/Misc/security_icons.rsi

State Old New Status
hud_discharged Added
hud_incarcerated Added
hud_paroled Added
hud_suspected Added
hud_wanted Added

@Morb0 Morb0 merged commit ca0e501 into master Mar 11, 2024
14 of 15 checks passed
@Morb0 Morb0 deleted the upstream-sync branch March 11, 2024 06:07
Morb0 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.