Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resprite brick&riveted walls #1826

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

Ko4ergaPunk
Copy link
Collaborator

Описание PR

Перерисовал кирпичную. Изменил клёпанную под перспективу стен корвакса

Медиа

walls

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑

@Ko4ergaPunk Ko4ergaPunk requested a review from Morb0 as a code owner January 31, 2024 05:16
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: No C# Code has not been changed labels Jan 31, 2024
Copy link
Contributor

github-actions bot commented Jan 31, 2024

RSI Diff Bot; head commit 884ba18 merging into 8bc6ff4
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Walls/brick.rsi

State Old New Status
brick0 Modified
brick1 Modified
brick2 Modified
brick3 Modified
brick4 Modified
brick5 Modified
brick6 Modified
brick7 Modified
full Modified

Resources/Textures/Structures/Walls/riveted.rsi

State Old New Status
full Modified
riveted0 Modified
riveted1 Modified
riveted2 Modified
riveted3 Modified
riveted4 Modified
riveted5 Modified
riveted6 Modified
riveted7 Modified

Edit: diff updated after 884ba18

@SonicHDC
Copy link
Collaborator

Круто, но клёпанная немного странная. Слишком сильно рябит в глазах.

@lzk228
Copy link
Collaborator

lzk228 commented Jan 31, 2024

мне не нравится клёпанная стена, она слишком яркая в центре

Copy link
Member

@Morb0 Morb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Согласен, клёпанную стену нужно пересмотреть. Меньше мелкого паттерна и уменьшить яркость в центре.

@Ko4ergaPunk
Copy link
Collaborator Author

Вроде теперь хайп
newWalls

@Ko4ergaPunk Ko4ergaPunk requested a review from Morb0 January 31, 2024 20:15
@Morb0 Morb0 merged commit c372139 into space-syndicate:master Feb 1, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants