Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert revert light fixtures sprites #1797

Closed
wants to merge 1 commit into from
Closed

Revert revert light fixtures sprites #1797

wants to merge 1 commit into from

Conversation

lzk228
Copy link
Collaborator

@lzk228 lzk228 commented Jan 24, 2024

Описание PR

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑

  • add: Добавлено веселье!
  • remove: Убрано веселье!
  • tweak: Изменено веселье!
  • fix: Исправлено веселье!

@lzk228 lzk228 requested a review from Morb0 as a code owner January 24, 2024 01:53
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged labels Jan 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

RSI Diff Bot; head commit de6c991 merging into 194c032
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Wallmounts/Lighting/light_tube.rsi

State Old New Status
base Modified
broken Modified
burned Modified
empty Modified
glow Modified

@SonicHDC
Copy link
Collaborator

Под стиль не подходят.
Лучше не надо.

@xKREKSx
Copy link
Contributor

xKREKSx commented Jan 24, 2024

дизлайк👎🏻

@Morb0
Copy link
Member

Morb0 commented Jan 24, 2024

Под стиль не подходят. Лучше не надо.

Они жёлтым светом светят, перекрасьте тогда старые

@SonicHDC
Copy link
Collaborator

SonicHDC commented Jan 24, 2024 •
edited
Loading

У них может быть свет разного цвета.
Тут скорее нужно кодить систему смены цвета лампы от того, чем она светит.
Но точно не ревёртить

@Morb0 Morb0 closed this Feb 26, 2024
@lzk228
Copy link
Collaborator Author

lzk228 commented Feb 26, 2024

сам попросил ревёртнуть и взял закрыл :trollface:

@lzk228 lzk228 deleted the 01-24-revert-revert branch February 26, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morb0 Morb0 Awaiting requested review from Morb0 Morb0 is a code owner

Assignees
No one assigned
Labels
Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzk228 @SonicHDC @xKREKSx @Morb0