Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Добавлена поддержка кириллицы для бриг и сигнал таймеров #1706

Merged
merged 3 commits into from
Jan 14, 2024

Conversation

778b
Copy link
Contributor

@778b 778b commented Dec 30, 2023

Описание PR

Добавлены спрайты для кириллицы, теперь все что имеет компонент TextScreenVisualsComponent (бриг-таймер и сигнал таймер) поддерживают кириллицу, ну и так же любой текст вне UI который будет иметь тот же принцип действия то же будет использовать эти наборы спрайтов.
close: #1541
Медиа

Content Client_iMx83tMYjk

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑 778b

  • add: Добавлена поддержка кириллицы для бриг и сигнал таймеров

@778b 778b requested a review from Morb0 as a code owner December 30, 2023 20:27
@github-actions github-actions bot added Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: No C# Code has not been changed Status: Needs Review This PR requires new reviews before it can be merged labels Dec 30, 2023
Copy link
Contributor

github-actions bot commented Dec 30, 2023

RSI Diff Bot; head commit bfc4172 merging into 7f43383
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Effects/text.rsi

State Old New Status
а Added
б Added
в Added
г Added
д Added
е Added
ж Added
з Added
и Added
й Added
к Added
л Added
м Added
н Added
о Added
п Added
р Added
с Added
т Added
у Added
ф Added
х Added
ц Added
ч Added
ш Added
щ Added
ъ Added
ы Added
ь Added
э Added
ю Added
я Added
ё Added

Edit: diff updated after bfc4172

@778b
Copy link
Contributor Author

778b commented Dec 30, 2023

ЗЫ. в другую папку спрайты не убрать, тк в коде явно прописан путь до них

@778b 778b changed the title Added sprites for cyrilic letters Добавлена поддержка кириллицы для бриг и сигнал таймеров Dec 30, 2023
Copy link
Member

@Morb0 Morb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавь себя в copyright поле

@778b 778b requested a review from Morb0 January 12, 2024 04:02
@Morb0 Morb0 merged commit 61fbd0c into space-syndicate:master Jan 14, 2024
9 checks passed
@778b 778b deleted the Cyrillic-letters-for-screens branch January 15, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

На бриг таймерах не работает кириллица
2 participants