Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream sync #1570

Merged
merged 104 commits into from
Nov 14, 2023
Merged

Upstream sync #1570

merged 104 commits into from
Nov 14, 2023

Conversation

Morb0
Copy link
Member

@Morb0 Morb0 commented Nov 14, 2023

Описание PR

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

themias and others added 30 commits November 8, 2023 18:42
* Add cotton plant

* Adddescription and tag to cotton bal allow moth eat it

* Fix typo. Add cotton seed into MegaSeed

* Fix typo

* Fix typo

* Fix cottonbol component typo

* Fix the amount of cotton that bol gives

* Adding correct component to make cotton bol edible

* Change cotton bol parent to see if it is edible

* Adding flavor to cotton bol, and fix typo

* Replace image

* fixing plant image position

* Increase the Megaseed restock crate price to avoid money farming loop hole
* Remove bad substitutions from dwarf accent

As per discussion in https://discord.com/channels/310555209753690112/1170959598153375815
These phrases are common pain-points
and often don't make gramatical sense
in most conversation

I feel accents (especially ones tied to species)
should favour intelligibility over flavour
where the trade-off arises

* Remove duplicate entry in dwarven accent

For -> fer already exists at accent-dwarf-words-82
…(#21547)

* Remove bad substitutions from dwarf accent

As per discussion in https://discord.com/channels/310555209753690112/1170959598153375815
These phrases are common pain-points
and often don't make gramatical sense
in most conversation

I feel accents (especially ones tied to species)
should favour intelligibility over flavour
where the trade-off arises

* Remove duplicate entry in dwarven accent

For -> fer already exists at accent-dwarf-words-82

* Revert removal of Hey -> Oye, opting for Hey -> Oi instead

* Revert removal of Hey -> Oye, opting for Hey -> Oi instead
* Oh well

* Minor fixing up

* HOLY BINGLE I DID IT

* TOGGLE!
* Update animals.yml

* Update

* ANOTHER UPDATE

change mobcat meleeweapon from brute to piercing, deleting extra lines

* oops

* Update npc.yml

* Update npc.yml

* Update animals.yml
* boirg stuff

* gaming

* modules shits

* mini welder is too lmao

* pro

* cheaper recipes, fix mob state thresholds, remove silly crayon, rename module

* generic borg 6 module

* literacy module shityourself
* Add dead states to borgs

* this?

* ack
Generators were discharged in the admin arena,
* Basic and advanced cleaning modules

* Roundstart entry level modules

* Oops forgot recipe

* Gold
@Morb0 Morb0 requested a review from ficcialfaint as a code owner November 14, 2023 15:53
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design labels Nov 14, 2023
Copy link
Contributor

github-actions bot commented Nov 14, 2023

RSI Diff Bot; head commit f45c72b merging into 7cbdc99
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Alerts/borg_alive.rsi

State Old New Status
health0 Modified
health1 Modified
health2 Modified
health3 Modified
health4 Modified

Resources/Textures/Mobs/Pets/cat.rsi

State Old New Status
cak Modified
kitten Modified
kittencollar Modified
kittentag Modified

Resources/Textures/Clothing/Neck/Cloaks/void.rsi

State Old New Status
equipped-NECK Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/Interface/Alerts/borg_critical.rsi

State Old New Status
critical Added

Resources/Textures/Interface/Alerts/borg_dead.rsi

State Old New Status
dead Added

Resources/Textures/Mobs/Aliens/Carps/sharkminnow.rsi

State Old New Status
alive Added
dead Added
dead_mouth Added
icon Added
mouth Added

Resources/Textures/Objects/Fun/figurines.rsi

State Old New Status
thiefcharacter Added

Resources/Textures/Objects/Specific/Hydroponics/cotton.rsi

State Old New Status
dead Added
harvest Added
produce Added
seed Added
stage-1 Added
stage-2 Added
stage-3 Added

Resources/Textures/Objects/Specific/Robotics/borgmodule.rsi

State Old New Status
icon-mop-adv Added

Resources/Textures/Objects/Storage/petcarrier.rsi

State Old New Status
icon Added
inhand-left Added
inhand-right Added
pet_carrier_base Added

Edit: diff updated after f45c72b

@Morb0 Morb0 merged commit e451598 into master Nov 14, 2023
12 checks passed
@Morb0 Morb0 deleted the upstream-sync branch November 14, 2023 16:53
Morb0 pushed a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Can be reviewed or fixed by people who are knowledgeable with translation Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: UI Can be reviewed or fixed by people who are knowledgeable with UI design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.