Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resprite some signs #1560

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Resprite some signs #1560

merged 4 commits into from
Nov 17, 2023

Conversation

lzk228
Copy link
Collaborator

@lzk228 lzk228 commented Nov 8, 2023

Описание PR

Медиа

Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

Изменения

🆑

  • add: Добавлено веселье!
  • remove: Убрано веселье!
  • tweak: Изменено веселье!
  • fix: Исправлено веселье!

lzk228 added 2 commits November 8, 2023 11:08
@lzk228
Add files via upload
0a89215 
court, janitor, law & psychology changed by netwy (discord, 583844759429316618)
@lzk228
Update meta.json
4863ea8
@lzk228 lzk228 requested a review from Morb0 as a code owner November 8, 2023 10:12
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Changes: No C# Code has not been changed labels Nov 8, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

RSI Diff Bot; head commit e510470 merging into 64b8975
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Structures/Wallmounts/signs.rsi

State Old New Status
court Modified
janitor Modified
law Modified
psychology Modified

Edit: diff updated after e510470

Morb0
Morb0 previously approved these changes Nov 8, 2023
View reviewed changes
@lapatison
Copy link
Contributor

В Суд, буквы С и Д выбивается из стиля существующих табличек
Должны быть С шире и скруглённее, у Д верхняя часть с другой стороны

Уборщик - хлам? И если так, почему бы Х как у психолога не сделать?

@Morb0 Morb0 merged commit df5f68c into space-syndicate:master Nov 17, 2023
11 checks passed
@lzk228 lzk228 deleted the res branch November 26, 2023 22:40
@TheArturZh TheArturZh mentioned this pull request Nov 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morb0 Morb0 Morb0 left review comments

Assignees
No one assigned
Labels
Changes: No C# Code has not been changed Changes: Sprites Should be reviewed or fixed by people who are knowledgeable with spriting or visual design Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lzk228 @lapatison @Morb0