Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Добавление Silly в пулл карт #1546

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Добавление Silly в пулл карт #1546

merged 5 commits into from
Nov 3, 2023

Conversation

TheShuEd
Copy link
Contributor

@TheShuEd TheShuEd commented Nov 2, 2023

Описание PR

Силли теперь в игре, и доступна в голосовании от 0 до 30 игроков. Да здраствуют томные ночные смены на силли.
Проверки

  • PR полностью завершён и мне не нужна помощь чтобы его закончить.
  • Я внимательно просмотрел все свои изменения и багов в них не нашёл.
  • Я запускал локальный сервер со своими изменениями и всё протестировал.
  • Я добавил скриншот/видео демонстрации PR в игре, или этот PR этого не требует.

🆑

  • add: Добавлена Silly в пул карт

@TheShuEd TheShuEd requested a review from Morb0 as a code owner November 2, 2023 17:02
@github-actions github-actions bot added Status: Needs Review This PR requires new reviews before it can be merged Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping labels Nov 2, 2023
@Morb0 Morb0 self-requested a review November 3, 2023 06:07
Morb0
Morb0 requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@Morb0 Morb0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed to load map CorvaxSilly
----> NUnit.Framework.AssertionException : SERVER: 0,102s [ERRO] map: Error in map file: found local entity UID '0' which does not exist. Exception:

@Morb0 Morb0 merged commit e1cd4c4 into space-syndicate:master Nov 3, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Morb0 Morb0 Morb0 approved these changes

Assignees
No one assigned
Labels
Changes: Map Can be reviewed or fixed by people who are knowledgeable with mapping Status: Needs Review This PR requires new reviews before it can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheShuEd @Morb0