[Fix?] Json generation for wiki works again #1504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UniversalJsonConverter now skips indexed params
github-actions
bot
added
the
Status: Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Фиксы:
Пофикшена ошибка
System.Reflection.TargetParameterCountException: Parameter count mismatch., которая вела к тому, что json не билдились после #1494.Я, честно, не знаю насколько это на самом деле fix, насколько он правильно сделан и можно ли сделать по другому, но текущий вариант работает отлично (должно как минимум, как максимум works on my pc:tm:), а новый json не имеет отличий от json, сделанного до прошлого апстрима.
Медиа
Проверки
Изменения
no cl