Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footprints #28

Merged
merged 13 commits into from
Nov 9, 2024
Merged

Footprints #28

merged 13 commits into from
Nov 9, 2024

Conversation

AwareFoxy
Copy link
Collaborator

@AwareFoxy AwareFoxy commented Nov 8, 2024

Описание PR

Добавляет следы в игру.
Спасибо Тресту.
Rxup/space-station-14#861

Медиа

image

Требования

Критические изменения

Список изменений
🆑

  • add: Следы добавлены в игру!

Copy link

github-actions bot commented Nov 8, 2024

RSI Diff Bot; head commit 13d8825 merging into 0047169
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_CorvaxNext/Effects/footprints.rsi

State Old New Status
dragging-1 Added
dragging-2 Added
dragging-3 Added
dragging-4 Added
dragging-5 Added
dragging-test Added
footprint-left-bare-diona Added
footprint-left-bare-dwarf Added
footprint-left-bare-human Added
footprint-left-bare-lizard Added
footprint-left-bare-slime Added
footprint-left-bare-spider Added
footprint-right-bare-diona Added
footprint-right-bare-dwarf Added
footprint-right-bare-human Added
footprint-right-bare-lizard Added
footprint-right-bare-slime Added
footprint-right-bare-spider Added
footprint-shoes Added
footprint-suit Added

Edit: diff updated after 13d8825

@FireNameFN
Copy link
Collaborator

FireNameFN commented Nov 8, 2024

Неймспейсы неправильные.
FootPrintComponent и FootPrintsComponent - слишком похожие названия.

Copy link
Collaborator Author

@AwareFoxy AwareFoxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix it

Resources/Prototypes/Entities/Mobs/Species/arachnid.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/diona.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/dwarf.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/human.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/moth.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/reptilian.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/skeleton.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/slime.yml Outdated Show resolved Hide resolved
Resources/Prototypes/Entities/Mobs/Species/vox.yml Outdated Show resolved Hide resolved
@AwareFoxy AwareFoxy merged commit 9031a52 into space-syndicate:master Nov 9, 2024
12 of 13 checks passed
@AwareFoxy
Copy link
Collaborator Author

не селфмердж всё было обсуждено с мейнтейнерами МАМОЙ КЛЯНУСЬ

@sashagavrilyuk
Copy link

sashagavrilyuk commented Nov 9, 2024

Почему следы и грязь добавил. А хирургию закрыли? Че за фигня?

@TokenStyle
Copy link

Почему следы и грязь добавил. А хирургию закрыли? Че за фигня?

Хирургию никто ни с кем не обсуждал, а следы обсудили. Да и хирургия как механика "in proccess" в реальном времени разрабатывается, а система следов/грязи уже много месяцев существует на разных серверах, и оптимизирована по максимуму напильником

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants