Снежки #179
Open
Снежки #179
+283
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaptainSqrBeard
requested review from
Vonsant,
Tornado-Technology,
AwareFoxy and
FireNameFN
as code owners
github-actions
bot
added
size/L
S: Untriaged
Changes: Sprites
S: Needs Review
|
RSI Diff Bot; head commit a706e92 merging into d6b89e7 Resources/Textures/_CorvaxNext/Objects/Misc/snowball.rsi
Resources/Textures/_CorvaxNext/Objects/Misc/snowball_maker.rsi
|
FireNameFN
requested changes
Dec 21, 2024
Comment on lines
+43
to
+46
| public override DoAfterEvent Clone() | ||
| { | ||
| return this; | ||
| } |
There was a problem hiding this comment.
Самый неглубокий Clone()
Comment on lines
+37
to
+41
| public FromTileCraftDoAfterEvent(NetEntity grid, Vector2i gridTile) | ||
| { | ||
| Grid = grid; | ||
| GridTile = gridTile; | ||
| } |
There was a problem hiding this comment.
я попробовал сделать это и у меня перестала билдится игра, хз
There was a problem hiding this comment.
так и не разобрался в чём проблема
Content.Shared/_CorvaxNext/FromTileCrafter/Systems/FromTileCrafterSystem.cs
Outdated
Show resolved
Hide resolved
Content.Shared/_CorvaxNext/FromTileCrafter/Systems/FromTileCrafterSystem.cs
Outdated
Show resolved
Hide resolved
Content.Shared/_CorvaxNext/FromTileCrafter/Systems/FromTileCrafterSystem.cs
Outdated
Show resolved
Hide resolved
FireNameFN
requested changes
Dec 22, 2024
Content.Shared/_CorvaxNext/FromTileCrafter/Systems/FromTileCrafterSystem.cs
Outdated
Show resolved
Hide resolved
Content.Shared/_CorvaxNext/FromTileCrafter/Systems/FromTileCrafterSystem.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание PR
Добавлены снежки. Их можно метать в людей и наносить урон по стамине.
Добавлен снежколеп, создающий снежки при клике на тайл снега. Его можно напечатать на автолате.
Почему / Баланс
Просто предмет для веселья на манер боксёрских перчаток.
Ссылка на ветку
Предложка: https://discord.com/channels/919301044784226385/1309045735894941788
(хотя предложка тут скорее просто источник некоторого вдохновения)
Ветка: https://discord.com/channels/919301044784226385/1319812837924667392
Технические детали
Destructible.Thresholds.Behaviors.SpillBehaviorполучил новое поле, дающее приглушить звук от выплёскивания реагентов.Новый компонент
FromTileCrafterComponentи системаFromTileCrafterSystemдля спавна при помощи объекта с этим компонентом по клику на определённые тайлы.Медиа
ss14_snowballs.mp4
Критические изменения
Список изменений
🆑 csqrb