Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branching history view/restore parameters #114

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

space-nuko
Copy link
Owner

@space-nuko space-nuko commented Jun 5, 2023

2023-06-03 00_18_19-http___localhost_3000_# - Chromium 2023-06-03 18_15_00-http___localhost_3000_# - Chromium

Needs improvements:

  • Performance is bad with lots of nodes
    • Linear view is better served as a virtual list like the normal history pane
    • History tree should be pruned when it gets too large
  • Parameters should be excludable from patch history, but includable in parameter restore, instead of both or none
    • Exclude both: image uploads, gallery view, display-only widgets (width/height preview for scale by modes)
    • Exclude from patch only: seed (randomized every gen, but doesn't make sense to branch off a new history for each seed change)
  • Parameter restore only shows the name of the individual parameter - just TEnc for a single LoRA weight - so it's difficult to associate which grouped parameter changed
    • At least include the names of containers the widget is contained in for better identification
  • Hovering a history node should show the diffs of the parameters in the UI, instead of just highlighting the changed UI elements
    • Also, can't see the highlights if the widget is off-screen
  • Restore parameters patches don't include combo widget parameters for some reason
  • Default workflow needs to be updated to support patch parameter exclusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant