Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port PVA unit tests #591

Closed
wants to merge 5 commits into from
Closed

Port PVA unit tests #591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8545c08
add PVA unit tests
JhontSouth Nov 4, 2024
be7f6fb
Merge branch 'main' of https://github.com/southworks/botbuilder-dotnet
JhontSouth Nov 4, 2024
1d11876
Clean up tests
ceciliaavila Nov 5, 2024
a2ec6ad
Merge branch 'main' into southworks/add/pva-unit-tests
ceciliaavila Nov 12, 2024
591792a
Remove unnecessary changes
ceciliaavila Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
328 changes: 328 additions & 0 deletions ...s/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/ValidLUContentWithComments.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,328 @@
{
"sections": [
{
"Errors": [

],
"SectionType": "SimpleIntentSection",
"Id": "simpleIntentSection_noUtterences",
"Body": "- \n",
"UtteranceAndEntitiesMap": [
{
"utterance": "",
"entities": [

],
"errorMsgs": [

],
"contextText": "- ",
"range": {
"Start": {
"Line": 4,
"Character": 0
},
"End": {
"Line": 4,
"Character": 2
}
}
}
],
"Entities": [

],
"Name": "noUtterences",
"IntentNameLine": "#noUtterences",
"Range": {
"Start": {
"Line": 3,
"Character": 0
},
"End": {
"Line": 5,
"Character": 0
}
}
},
{
"Errors": [

],
"SectionType": "SimpleIntentSection",
"Id": "simpleIntentSection_cancel",
"Body": "> this comment is just after the intent\n- cancel\n- please cancel that\n> this comment is in the middle of utterences\n- stop that\n\n> this comment is between sections\n",
"UtteranceAndEntitiesMap": [
{
"utterance": "cancel",
"entities": [

],
"errorMsgs": [

],
"contextText": "- cancel",
"range": {
"Start": {
"Line": 8,
"Character": 0
},
"End": {
"Line": 8,
"Character": 8
}
}
},
{
"utterance": "please cancel that",
"entities": [

],
"errorMsgs": [

],
"contextText": "- please cancel that",
"range": {
"Start": {
"Line": 9,
"Character": 0
},
"End": {
"Line": 9,
"Character": 20
}
}
},
{
"utterance": "stop that",
"entities": [

],
"errorMsgs": [

],
"contextText": "- stop that",
"range": {
"Start": {
"Line": 11,
"Character": 0
},
"End": {
"Line": 11,
"Character": 11
}
}
}
],
"Entities": [

],
"Name": "cancel",
"IntentNameLine": "# cancel",
"Range": {
"Start": {
"Line": 6,
"Character": 0
},
"End": {
"Line": 14,
"Character": 0
}
}
},
{
"Errors": [

],
"SectionType": "SimpleIntentSection",
"Id": "simpleIntentSection_help",
"Body": "- help\n- I need help\n- please help me\n- can you help\n",
"UtteranceAndEntitiesMap": [
{
"utterance": "help",
"entities": [

],
"errorMsgs": [

],
"contextText": "- help",
"range": {
"Start": {
"Line": 16,
"Character": 0
},
"End": {
"Line": 16,
"Character": 6
}
}
},
{
"utterance": "I need help",
"entities": [

],
"errorMsgs": [

],
"contextText": "- I need help",
"range": {
"Start": {
"Line": 17,
"Character": 0
},
"End": {
"Line": 17,
"Character": 13
}
}
},
{
"utterance": "please help me",
"entities": [

],
"errorMsgs": [

],
"contextText": "- please help me",
"range": {
"Start": {
"Line": 18,
"Character": 0
},
"End": {
"Line": 18,
"Character": 16
}
}
},
{
"utterance": "can you help",
"entities": [

],
"errorMsgs": [

],
"contextText": "- can you help",
"range": {
"Start": {
"Line": 19,
"Character": 0
},
"End": {
"Line": 19,
"Character": 14
}
}
}
],
"Entities": [

],
"Name": "help",
"IntentNameLine": "# help",
"Range": {
"Start": {
"Line": 15,
"Character": 0
},
"End": {
"Line": 20,
"Character": 0
}
}
},
{
"Errors": [

],
"SectionType": "SimpleIntentSection",
"Id": "simpleIntentSection_weather",
"Body": "- get weather\n- weather\n- how is the weather\n\n> final comment",
"UtteranceAndEntitiesMap": [
{
"utterance": "get weather",
"entities": [

],
"errorMsgs": [

],
"contextText": "- get weather",
"range": {
"Start": {
"Line": 22,
"Character": 0
},
"End": {
"Line": 22,
"Character": 13
}
}
},
{
"utterance": "weather",
"entities": [

],
"errorMsgs": [

],
"contextText": "- weather",
"range": {
"Start": {
"Line": 23,
"Character": 0
},
"End": {
"Line": 23,
"Character": 9
}
}
},
{
"utterance": "how is the weather",
"entities": [

],
"errorMsgs": [

],
"contextText": "- how is the weather",
"range": {
"Start": {
"Line": 24,
"Character": 0
},
"End": {
"Line": 24,
"Character": 20
}
}
}
],
"Entities": [

],
"Name": "weather",
"IntentNameLine": "# weather",
"Range": {
"Start": {
"Line": 21,
"Character": 0
},
"End": {
"Line": 26,
"Character": 15
}
}
}
],
"content": "> this is the first comment outside of any section\n\n#noUtterences\n- \n\n# cancel\n> this comment is just after the intent\n- cancel\n- please cancel that\n> this comment is in the middle of utterences\n- stop that\n\n> this comment is between sections\n\n# help\n- help\n- I need help\n- please help me\n- can you help\n\n# weather\n- get weather\n- weather\n- how is the weather\n\n> final comment",
"errors": [

]
}
26 changes: 26 additions & 0 deletions tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Fixtures/ValidLUContentWithComments.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
> this is the first comment outside of any section

#noUtterences
-

# cancel
> this comment is just after the intent
- cancel
- please cancel that
> this comment is in the middle of utterences
- stop that

> this comment is between sections

# help
- help
- I need help
- please help me
- can you help

# weather
- get weather
- weather
- how is the weather

> final comment
6 changes: 6 additions & 0 deletions ...sers/Microsoft.Bot.Builder.Parsers.LU.Tests/Microsoft.Bot.Builder.Parsers.LU.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1913,6 +1913,12 @@
<None Update="Fixtures\testLU309.txt">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Update="Fixtures\ValidLUContentWithComments.json">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
<None Update="Fixtures\ValidLUContentWithComments.txt">
<CopyToOutputDirectory>Always</CopyToOutputDirectory>
</None>
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\..\libraries\Parsers\Microsoft.Bot.Builder.Parsers.LU\Microsoft.Bot.Builder.Parsers.LU.csproj" />
Expand Down
4 changes: 1 addition & 3 deletions tests/Parsers/Microsoft.Bot.Builder.Parsers.LU.Tests/Parser/LuParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@
using System;
using System.IO;
using System.Runtime.InteropServices;
using System.Text;
using System.Text.RegularExpressions;
using Microsoft.Bot.Builder.Parsers.LU;
using Newtonsoft.Json;
using Xunit;

Expand All @@ -19,6 +16,7 @@ public class LuParserTests
[InlineData("SectionsLU")]
[InlineData("ImportAllLu")]
[InlineData("AllComments")]
[InlineData("ValidLUContentWithComments")]
public void ParseLuContent(string fileName)
{
// var luContent = "# Help"+ Environment.NewLine + "- help" + Environment.NewLine + "- I need help" + Environment.NewLine + "- please help";
Expand Down
Loading