Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: [Create Bot Page] Multiples errors related to the Name property of page elements #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: [Create Bot Page] Multiples errors related to the Name property of page elements #4

wants to merge 2 commits into from

Conversation

luislera
Copy link

@luislera luislera commented Oct 7, 2021 •
edited
Loading

Description

As reported at the issue, the following errores were fixed on this PR:

  • The Name property must not include the element's control type
  • The Name must not include the same text as the LocalizedControlType

Changes made

  • Updated the aria-label value for the menu icon element.
  • Updated the aria-label value for the breadcrumb element.

Screenshots

Both errors are not reported anymore
imagen

@luislera luislera changed the title Fix: [Create Bot Page] The Name property must not include the element's control type Fix: [Create Bot Page] Multiples errors related to the Name property of page elements Oct 7, 2021
@luislera luislera self-assigned this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoBernal FedericoBernal FedericoBernal approved these changes

@matiasroldan6 matiasroldan6 matiasroldan6 approved these changes

Assignees

@matiasroldan6 matiasroldan6

@luislera luislera

@FedericoBernal FedericoBernal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@luislera @matiasroldan6 @FedericoBernal