Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4009] Update samples to support latest Node version - TypeScript #431

Closed
wants to merge 7 commits into from

Conversation

ceciliaavila
Copy link

@ceciliaavila ceciliaavila commented Aug 26, 2024

Addresses # 4009

Description

This PR updates the ARM templates of the TypeScript samples to use Node 20 as default.

Proposed Changes

  • Updated Node to version 20 in all ARM templates.
  • Upgraded the restify dependency to version 10.0.0 and the @types/restify to 8.5.12.
  • Fixed error with missing moment module in 13.core-bot sample.
  • Fixed missing 'next' parameter in '/api/messages' handler to comply with new restify's requirements.
  • Updated Node required version in README files.

Testing

These images show the resources created in Azure and a bot working after the deployment.
image

Copy link

@JhontSouth JhontSouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the README file would require to change the node version used to test.

image

@ceciliaavila
Copy link
Author

I think that the README file would require to change the node version used to test.

image

mmm.... yes, maybe we could use node 18 or greater.

@iberlot iberlot force-pushed the southworks/update/node-20-ts branch from c3cf805 to 0d87dc7 Compare August 29, 2024 19:13
@ceciliaavila
Copy link
Author

/promoted 4011

@ceciliaavila ceciliaavila deleted the southworks/update/node-20-ts branch August 29, 2024 20:27
@sw-joelmut sw-joelmut restored the southworks/update/node-20-ts branch September 23, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants