Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Add details to README in certificate samples #427

Closed
wants to merge 7 commits into from

Conversation

JhontSouth
Copy link

#minor

Description

This PR adds more information to the README certificate samples to have an easier complete guide for SSL/TLS certificate configuration.

Proposed Changes

  • Updated Readme of node js samples 84.bot-authentication-certificate and 85.bot-authentication-sni.

@sw-joelmut sw-joelmut changed the title [DotNet] Add details to README in certificate samples [JS] Add details to README in certificate samples Jun 7, 2024
Copy link

@sw-joelmut sw-joelmut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar changes made for .NET could be made here #429.
Also, the linked images are not showing up in the readme.

Copy link

@andres-robinet-sw andres-robinet-sw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check casing of links.
If repo is cloned in linux/unix system, then Images is not the same as images.

@JhontSouth
Copy link
Author

Similar changes made for .NET could be made here #429. Also, the linked images are not showing up in the readme.

Changes applied

@@ -1,4 +1,3 @@
MicrosoftAppTenantId=

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed we dont have the MicrosoftAppTenantId and MicrosoftAppType, whe should include them here in the .env and the index.js, because they could be used with this flow path.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added Tenant Id

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The app type should be added as well, i know its not in the ConfigurationBotFrameworkAuthenticationOptions, but it is in the https://github.com/microsoft/botbuilder-js/blob/066b405a8630e4f6c7d165ef939982181f6bbc6a/libraries/botbuilder-core/src/configurationServiceClientCredentialFactory.ts which is the one that instantiates the CertificateServiceClientCredentialsFactory

@JhontSouth
Copy link
Author

Promoted /3994

@JhontSouth JhontSouth closed this Jun 19, 2024
@JhontSouth JhontSouth deleted the southworks/update/certificate-guides-js branch June 19, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants