-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DotNet] Add details to README in certificate samples #421
Conversation
Include az login step |
I created #429 to improve the readme, and merge it to this pr once approved For SNI it also applies the same principles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should replace this https://github.com/southworks/BotBuilder-Samples/pull/421/files#diff-7dbeff6709649d9c6e9229f72bcdc4d92ab7e4b89670961266729f98010d7769R55-R58 with the CertificateServiceClientCredentialsFactory like the normal certificate sample, but sendX5c.
I guess that you are referring to this(the link doesn't work): Instead of:
|
Yes, also the image in the readme should be updated. |
solved |
Promoted /3995 |
#minor
Description
This PR adds more information to the README certificate samples to have an easier complete guide for SSL/TLS certificate configuration.
Proposed Changes