Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for [JENKINS-72181] -- Jenkins-cli groovy command does not return stdout and stderr (regression in 2.427) #814

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Roshans007
Copy link

Description

In order to fix JENKINS-72181, introduced in Jenkins version 2.427, we will have to add out.flush() so that the cookbook can print & get the slave jnlp secret correctly.

Issues Resolved

With the latest Jenkins version 2.427 onwards, jenkins-cli groovy command does not return stdout and stderr. So cookbook was not able to get the slave jnlp secret correctly and was not able to register with the master.

This change should fix the issue.

Check List

  • A summary of changes made is included in the CHANGELOG under ## Unreleased
  • New functionality includes testing.
  • New functionality has been documented in the README if applicable.

In order to fix JENKINS-72181, introduced in Jenkins version 2.427, we will have to add out.flush() so that we can print & get the slave jnlp secret
@Roshans007 Roshans007 requested a review from a team as a code owner October 20, 2023 12:15
@damacus
Copy link
Member

damacus commented Oct 26, 2023

can you add your PR description to the CHANGELOG and I can release this, this afternoon.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants