-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feature/swarm #940
base: main
Are you sure you want to change the base?
[WIP] Feature/swarm #940
Conversation
@elthariel are you still working on this? |
@kmf Yes, I'm currently battle testing it in prod and applying bugfixes |
How's this coming along? |
It looks like there might be some examples or at least implementation that could be compared with someone who has done this a slightly different way. |
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
@elthariel are you still planning on finishing this or not? |
We're still using it in prod on our fleet. If you think you'll have the time to review it, I can have a look at rebasing it and everything. Not all of the docker swarm attributes are implemented, but they're easy to add and the core of the feature set works |
@elthariel we should have time to review it! |
@elthariel if you get this rebased we can start getting the tests working etc and look to get this merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 6 out of 15 changed files in this pull request and generated 2 suggestions.
Files not reviewed (9)
- libraries/helpers_swarm_network.rb: Evaluated as low risk
- test/cookbooks/docker_test/recipes/swarm.rb: Evaluated as low risk
- spec/docker_test/docker_swarm_spec.rb: Evaluated as low risk
- libraries/helpers_swarm_service.rb: Evaluated as low risk
- libraries/helpers_base.rb: Evaluated as low risk
- libraries/helpers_swarm_base.rb: Evaluated as low risk
- libraries/helpers_swarm_cluster.rb: Evaluated as low risk
- libraries/_autoload.rb: Evaluated as low risk
- libraries/docker_swarm_manager.rb: Evaluated as low risk
Description
This is a work in progress implementation of the basic features of docker swarm in this cookbook.
It's not intended to be anywhere near feature complete, but I hope it'll provide a good place to start for people with more advanced needs than mine.
I'm submitting this PR quite early but I already need to get my implementation path validated by people with more knowledge of this cookbook
Issues Resolved
#801
#862
Check List