Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Feature/swarm #940

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Conversation

elthariel
Copy link

Description

This is a work in progress implementation of the basic features of docker swarm in this cookbook.

It's not intended to be anywhere near feature complete, but I hope it'll provide a good place to start for people with more advanced needs than mine.

I'm submitting this PR quite early but I already need to get my implementation path validated by people with more knowledge of this cookbook

Issues Resolved

#801
#862

Check List

@elthariel elthariel requested a review from a team November 30, 2017 09:46
@kmf
Copy link

kmf commented Jan 18, 2018

@elthariel are you still working on this?

@elthariel
Copy link
Author

@kmf Yes, I'm currently battle testing it in prod and applying bugfixes

@isuftin
Copy link
Contributor

isuftin commented Jun 7, 2018

How's this coming along?

@tas50 tas50 removed the request for review from a team July 19, 2018 19:25
@espoelstra
Copy link

It looks like there might be some examples or at least implementation that could be compared with someone who has done this a slightly different way.
https://gitlab.com/chef-platform/docker-platform

elthariel added 15 commits June 7, 2019 08:59
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
Signed-off-by: Julien 'Lta' BALLET <[email protected]>
@ramereth
Copy link
Contributor

@elthariel are you still planning on finishing this or not?

@elthariel
Copy link
Author

We're still using it in prod on our fleet. If you think you'll have the time to review it, I can have a look at rebasing it and everything.

Not all of the docker swarm attributes are implemented, but they're easy to add and the core of the feature set works

@ramereth
Copy link
Contributor

@elthariel we should have time to review it!

@ramereth ramereth added Feature Request Enhancement to existing functionality or new functionality Waiting on Contributor Awaiting on the person who raised this to update labels Oct 27, 2020
@ramereth ramereth marked this pull request as draft November 2, 2020 20:20
@xorima
Copy link
Contributor

xorima commented Nov 20, 2020

@elthariel if you get this rebased we can start getting the tests working etc and look to get this merged

@damacus damacus added the hacktoberfest-accepted PR has been accepted for hacktoberfest 2020. Waiting on merge label Oct 4, 2022
@damacus damacus closed this Oct 4, 2022
@damacus damacus reopened this Dec 11, 2024
@damacus damacus requested review from Copilot and removed request for someara, bflad, chasebolt and scalp42 December 11, 2024 22:15

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 15 changed files in this pull request and generated 2 suggestions.

Files not reviewed (9)
  • libraries/helpers_swarm_network.rb: Evaluated as low risk
  • test/cookbooks/docker_test/recipes/swarm.rb: Evaluated as low risk
  • spec/docker_test/docker_swarm_spec.rb: Evaluated as low risk
  • libraries/helpers_swarm_service.rb: Evaluated as low risk
  • libraries/helpers_base.rb: Evaluated as low risk
  • libraries/helpers_swarm_base.rb: Evaluated as low risk
  • libraries/helpers_swarm_cluster.rb: Evaluated as low risk
  • libraries/_autoload.rb: Evaluated as low risk
  • libraries/docker_swarm_manager.rb: Evaluated as low risk
@sous-chefs sous-chefs deleted a comment from Copilot bot Dec 12, 2024
@sous-chefs sous-chefs deleted a comment from Copilot bot Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement to existing functionality or new functionality hacktoberfest-accepted PR has been accepted for hacktoberfest 2020. Waiting on merge Waiting on Contributor Awaiting on the person who raised this to update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants