Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: enable dayhoff, hp sketching #55

Merged
merged 7 commits into from
Jun 14, 2024
Merged

MRG: enable dayhoff, hp sketching #55

merged 7 commits into from
Jun 14, 2024

Conversation

bluegenes
Copy link
Collaborator

@bluegenes bluegenes commented Jun 13, 2024

Adds dayhoff and hp sketching of protein files

  • Modifies parse_params_str and build_sig to parse dayhoff and hp in params and build signature templates. Protein signature templates will now include all protein, dayhoff, hp sigs. These functions are now used both in branchwater manysketch and here, so are good candidates for going back into sourmash, probably here: src/core/src/cmd.rs

General note: we do not yet support translated sketches, so dayhoff and hp (like protein) will only be made from protein files.

@bluegenes bluegenes changed the base branch from main to zip-permissions June 13, 2024 23:45
@bluegenes bluegenes changed the title enable dayhoff, hp sketching MRG: enable dayhoff, hp sketching Jun 13, 2024
@bluegenes
Copy link
Collaborator Author

@ctb also ready for review

Base automatically changed from zip-permissions to main June 14, 2024 16:33
@bluegenes bluegenes merged commit 6672f88 into main Jun 14, 2024
1 check passed
@bluegenes bluegenes deleted the dayhoff-hp branch June 14, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants