MRG: Fix scaled determination in fastgather and fastmultigather
#498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* debug gather scaled problem * cleanup & rationalize * more cleanup
ctb
changed the title
fastmultigatherfastgather and fastmultigather
…water into fix_scaled
…branchwater into fix_scaled
…water into fix_scaled
ctb
changed the title
fastgather and fastmultigatherfastgather and fastmultigather
|
Ready for review & merge @bluegenes ! |
…water into fix_scaled
bluegenes
reviewed
Nov 6, 2024
This was referenced Nov 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #491
This PR updates
fastgatherandfastmultigatheragainst rocksdb to pick scaled automatically, rather than using a default value of 1000.fastmultigathernow exits when no search sketches are found.scaled=1000is removed as the default throughout.It also eliminates the use of usize throughout the codebase in favor of u32/u64, following sourmash-bio/sourmash#3364.
TODO: