-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: update docs and -h
messages for v0.9.5 release
#364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple suggested changes, but otherwise lgtm!
|
||
The main advantage that `fastmultigather` has over running `fastgather` on multiple queries is that you only load the database files once with `fastmultigather`, which can be a significant time savings for large databases! | ||
The main advantage that `fastmultigather` has over running `fastgather` on multiple queries is that `fastmultigather` only needs to load the database once for all queries, unlike with `fastgather`; this can be a significant time savings for large databases! | ||
|
||
#### Output files for `fastmultigather` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this section, should we now add some text on how rocksdb fastmultigather differs (single output file for all results, no prefetch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in 0f6a077
Co-authored-by: Tessa Pierce Ward <[email protected]>
…water into update_docs_095
This PR follows #360 and #361, which fix the gather output to be ~100% sourmash compatible.
This PR:
-h/--help
messagesindex
doesn't work with a text file list of manifests #347;Fixes #329
Fixes #350
Fixes #362