-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRG: standardize on u32 for scaled, and introduce ScaledType
#3364
Merged
Merged
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2f78db6
standardize on u64 for scaled, and others
ctb 54bfd70
fix --all-features
ctb b6fbaf9
fix clippy
ctb 874f54d
cargo fmt
ctb 8c99c65
Merge branch 'latest' of github.com:sourmash-bio/sourmash into update…
ctb b63bf85
set scaled to u32
ctb 658e398
fix one last
ctb 25d326a
fiz
ctb cc67a4f
fix more
ctb f124f5c
upd sourmash.h
ctb a88d428
bump sourmash-rs core version
ctb ae702b5
start fixing all the tests, sigh
ctb f283c4e
update to use ScaledType
ctb 72a50c5
more tests fixed
ctb d768a06
fixed
ctb 8c2d226
rest of fixes?
ctb c80a546
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] b665b00
Merge branch 'latest' of github.com:sourmash-bio/sourmash into update…
ctb 2989021
cargo fmt
ctb 4fb0b0f
fix wasm
luizirber 58fb956
use ScaledType in FFI
luizirber 5f49d1c
upd include
ctb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
k! was wondering where to do the conversion ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ScaledType
is just an alias, so it gets resolved tou32
ininclude/sourmash.h
. So it doesn't change much now, but easier to play with differentScaledType
values in the future =]