Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: refactor calculate_gather_stats to disallow repeated downsampling #3352

Merged
merged 29 commits into from
Oct 15, 2024

Merge branch 'latest' of github.com:sourmash-bio/sourmash into gather…

405c518
Select commit
Loading
Failed to load commit list.
Merged

MRG: refactor calculate_gather_stats to disallow repeated downsampling #3352

Merge branch 'latest' of github.com:sourmash-bio/sourmash into gather…
405c518
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 14, 2024 in 1s

86.42% (-0.10%) compared to b7fb659

View this Pull Request on Codecov

86.42% (-0.10%) compared to b7fb659

Details

Codecov Report

Attention: Patch coverage is 70.83333% with 21 lines in your changes missing coverage. Please review.

Project coverage is 86.42%. Comparing base (b7fb659) to head (405c518).
Report is 24 commits behind head on refactor_rs_downsample.

Files with missing lines Patch % Lines
src/core/src/signature.rs 10.00% 9 Missing ⚠️
src/core/src/sketch/minhash.rs 80.00% 9 Missing ⚠️
src/core/src/storage/mod.rs 0.00% 2 Missing ⚠️
src/core/src/index/mod.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           refactor_rs_downsample    #3352      +/-   ##
==========================================================
- Coverage                   86.52%   86.42%   -0.10%     
==========================================================
  Files                         137      137              
  Lines                       16046    16070      +24     
  Branches                     2215     2211       -4     
==========================================================
+ Hits                        13883    13889       +6     
- Misses                       1856     1874      +18     
  Partials                      307      307              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.