Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove match_ #3351

Draft
wants to merge 2 commits into
base: latest
Choose a base branch
from
Draft

remove match_ #3351

wants to merge 2 commits into from

Conversation

luizirber
Copy link
Member

I think match_ is a leftover from the first impl of Index on the rust side, and not needed?

Base automatically changed from refactor_rs_downsample to latest October 15, 2024 17:12
@luizirber luizirber force-pushed the lirber/remove_match_ branch from 00cbecf to 4841d43 Compare November 12, 2024 01:00
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.43%. Comparing base (11cab80) to head (06867ac).

Files with missing lines Patch % Lines
src/core/src/ffi/index/revindex.rs 0.00% 1 Missing ⚠️
src/core/src/index/revindex/mem_revindex.rs 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           latest    #3351      +/-   ##
==========================================
- Coverage   86.45%   86.43%   -0.03%     
==========================================
  Files         137      137              
  Lines       16092    16086       -6     
  Branches     2219     2219              
==========================================
- Hits        13913    13904       -9     
- Misses       1872     1875       +3     
  Partials      307      307              
Flag Coverage Δ
hypothesis-py 25.43% <ø> (ø)
python 92.40% <ø> (ø)
rust 62.03% <81.81%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ctb
Copy link
Contributor

ctb commented Nov 12, 2024

This seems ready, yes?

@luizirber
Copy link
Member Author

This seems ready, yes?

sorta, still need to resolve the todo!() in FFI code (for something that is not used in the Python layer, but requires access to the sig...), and without passing the sig in GatherResult I think there is more that can be refactor. Might leave this one for a future PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants