Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: update docs for tax grep: only searches tax #2789

Merged
merged 1 commit into from
Sep 28, 2023
Merged

MRG: update docs for tax grep: only searches tax #2789

merged 1 commit into from
Sep 28, 2023

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Sep 28, 2023

Updates tax grep documentation to make it clear that it only searches taxonomic
ranks, not identifiers; sig grep searches sketch names.

Fixes #2607

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2789 (a666c8b) into latest (f19af8c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           latest    #2789   +/-   ##
=======================================
  Coverage   85.94%   85.94%           
=======================================
  Files         130      130           
  Lines       14808    14808           
  Branches     2621     2621           
=======================================
  Hits        12727    12727           
  Misses       1780     1780           
  Partials      301      301           
Flag Coverage Δ
hypothesis-py 25.82% <ø> (ø)
python 92.85% <ø> (ø)
rust 49.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/sourmash/cli/tax/grep.py 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@bluegenes bluegenes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@ctb ctb merged commit ba1fd3e into latest Sep 28, 2023
35 checks passed
@ctb ctb deleted the doc/tax_grep branch September 28, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tax grep doesn't search the identifiers!
2 participants