change Signature::name() to Option<String>

src/core/src/manifest.rs

@@ -129,7 +129,7 @@ impl Record {
                 Self {
                     internal_location: path.into(),
                     moltype: moltype.to_string(),
-                    name: sig.name(),
+                    name: sig.name().unwrap_or("".into()),
                     ksize,
                     md5,
                     md5short,

src/core/src/signature.rs

@@ -445,11 +445,11 @@ fn default_version() -> f64 {
 }
 
 impl Signature {
-    pub fn name(&self) -> String {
+    pub fn name(&self) -> Option<String> {
         if let Some(name) = &self.name {
-            name.clone()
+            Some(name.clone())
         } else {
-            "".into()
+            None
         }
     }
 
@@ -981,7 +981,7 @@ mod test {
         assert_eq!(sig.signatures[1].size(), 2);
         assert_eq!(sig.signatures[2].size(), 1);
 
-        assert_eq!(sig.name(), "");
+        assert_eq!(sig.name().unwrap_or("".into()), "");
     }
 
     #[test]

src/core/src/storage/mod.rs

@@ -466,7 +466,7 @@ impl ZipStorage {
 
 impl SigStore {
     pub fn new_with_storage(sig: Signature, storage: InnerStorage) -> Self {
-        let name = sig.name();
+        let name = sig.name().unwrap_or("".into());
         let filename = sig.filename();
 
         SigStore::builder()
@@ -555,7 +555,7 @@ impl Deref for SigStore {
 
 impl From<Signature> for SigStore {
     fn from(other: Signature) -> SigStore {
-        let name = other.name();
+        let name = other.name().unwrap_or("".into());
         let filename = other.filename();
 
         SigStore::builder()

src/core/tests/storage.rs

@@ -98,7 +98,7 @@ fn innerstorage_save_sig() -> Result<(), Box<dyn std::error::Error>> {
 
     let loaded_sig = instorage.load_sig("test")?;
 
-    assert_eq!(sig.name(), loaded_sig.name());
+    assert_eq!(sig.name().unwrap_or("".into()), loaded_sig.name());
     assert_eq!(sig.md5sum(), loaded_sig.md5sum());
 
     Ok(())