-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: link to dashboard from status bar #255
Conversation
Reviewer's Guide by SourceryThis PR updates the Sourcery extension to open the Sourcery dashboard in a browser when the status bar item is clicked. Previously, it opened a webview panel within VS Code. Sequence diagram: Status bar click behavior before and after changessequenceDiagram
actor User
participant StatusBar
participant VSCode
participant Browser
rect rgb(200, 200, 200)
Note over User,Browser: Before changes
User->>StatusBar: Click status bar item
StatusBar->>VSCode: Open Hub webview panel
VSCode-->>User: Show Hub panel in VS Code
end
rect rgb(173, 216, 230)
Note over User,Browser: After changes
User->>StatusBar: Click status bar item
StatusBar->>Browser: Open dashboard URL
Browser-->>User: Show Sourcery dashboard
end
[FILTERED - User journey diagrams are low quality] User journey diagram: Managing Sourcery accountjourney
title Managing Sourcery Account
section Before
Click status bar: 5: User
View Hub panel: 3: User
section After
Click status bar: 5: User
View dashboard in browser: 4: User
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Hellebore - I've reviewed your changes - here's some feedback:
Overall Comments:
- Since package.json was modified, please verify that the VSIX package works with a direct install as mentioned in the PR checklist
- This changes the UX from an integrated webview to opening in external browser. Could you explain the rationale for this change and any UX considerations that were taken into account?
Here's what I looked at during the review
- 🟢 Functionality: all looks good
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Review instructions: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Checklist
package.json
oryarn.lock
have changed, then test the VSIX built byyarn run vsce package
works from a direct installSummary by Sourcery
New Features: