Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle configuration changes from the app #241

Merged

Conversation

bm424
Copy link
Contributor

@bm424 bm424 commented Dec 13, 2023

  • Adds a handler for messages telling the extension to update its configuration.

Note that VSCode handles calling the language server to update configuration.

See core changes: https://github.com/sourcery-ai/core/pull/3398
See Intellij changes: https://github.com/sourcery-ai/intellij-plugin/pull/148

@bm424 bm424 self-assigned this Dec 13, 2023
@bm424 bm424 marked this pull request as ready for review December 13, 2023 12:50
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

Summary of PR: This PR introduces a new feature to handle configuration updates from the app by adding a message handler for updating the extension's configuration.

General PR suggestions

  • Consider refining the type definition for the value field in the updateConfiguration message to enhance type safety and avoid potential issues.
  • Review the naming of the configurationTarget field to ensure it clearly communicates its purpose and consider aligning it with the VS Code API's conventions.
  • Implement error handling for the new configuration update functionality to gracefully manage any issues that may arise during the update process.

src/chat.ts Outdated Show resolved Hide resolved
src/chat.ts Outdated Show resolved Hide resolved
src/chat.ts Show resolved Hide resolved
src/chat.ts Show resolved Hide resolved
@Hellebore Hellebore self-requested a review December 14, 2023 08:31
Copy link
Contributor

@Hellebore Hellebore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

src/chat.ts Outdated Show resolved Hide resolved
src/chat.ts Outdated Show resolved Hide resolved
@bm424 bm424 merged commit 08c775e into main Dec 15, 2023
1 check passed
@bm424 bm424 deleted the ben/sou-2022-feat-add-a-settings-cog-to-the-coding-assistant branch December 15, 2023 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants