Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure directory links work in VSCode #232

Merged
merged 3 commits into from
Oct 6, 2023
Merged

fix: ensure directory links work in VSCode #232

merged 3 commits into from
Oct 6, 2023

Conversation

bm424
Copy link
Contributor

@bm424 bm424 commented Oct 6, 2023

  • Uses URIs in place of strings, and also adds a follow-up command to correctly focus a directory in VSCode

@bm424 bm424 requested a review from Hellebore October 6, 2023 15:03
@bm424 bm424 self-assigned this Oct 6, 2023
Hellebore
Hellebore approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@Hellebore Hellebore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it and it worked!

src/chat.ts Outdated Show resolved Hide resolved
@bm424 bm424 merged commit 7e530b3 into main Oct 6, 2023
1 check passed
@bm424 bm424 deleted the ben/sou-2032-fix-ensure-directory-links-work-in-vs-code-and-intellij branch October 6, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hellebore Hellebore Hellebore approved these changes

Assignees

@bm424 bm424

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bm424 @Hellebore