Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust path parsing to allow correct URI on Windows #226

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

bm424
Copy link
Contributor

@bm424 bm424 commented Sep 20, 2023

Use .file() rather than .parse() so that windows paths are parsed correctly. file doesn't seem to actually need a file specifically, a directory will do.

@bm424 bm424 requested a review from Hellebore September 20, 2023 10:41
@bm424 bm424 self-assigned this Sep 20, 2023
Copy link
Contributor

@Hellebore Hellebore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work finding the fix!

src/chat.ts Outdated Show resolved Hide resolved
@bm424 bm424 merged commit 496f1be into main Sep 20, 2023
@bm424 bm424 deleted the ben/sou-1988-bug-webview-not-loading-on-windows branch September 20, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants