feat: Trigger on opened PR, ready for review or sourcery-review label
#4
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Sourcery Review:
PR Type: Enhancement
Summary of PR: This PR updates the GitHub Actions workflow to trigger the Sourcery code review when a pull request is opened in a non-draft state, when it transitions from draft to ready for review, or when the sourcery-review label is applied.
General PR suggestions
- Ensure that the logical conditions in the workflow file are correctly ordered to prevent any unintended behavior. Specifically, use parentheses to clarify the order of evaluation in logical expressions.
- Review the comments in the workflow file for clarity and consistency. Make sure that the comments accurately describe the conditions under which the workflow is triggered.
- Consider any edge cases that might affect when the workflow should be triggered, such as the presence of specific labels that might indicate a pull request is not yet ready for review even if it is not in draft state.
There was a problem hiding this comment.
Sourcery Review:
PR Type: Enhancement
Summary of PR: This PR updates the GitHub Actions workflow to trigger the Sourcery code review on additional events, specifically when a pull request is opened (provided it's not a draft), when a draft pull request is marked as ready for review, and when the sourcery-review label is applied.
General PR suggestions
- Ensure that the comments in the workflow file are consistent and clear, especially where triggers for the actions are described. This helps maintain readability and understanding of the workflow's purpose.
- Review the logical expressions used in the workflow's conditional statements to prevent any unintended behavior due to operator precedence. Using parentheses to group conditions can improve clarity and correctness.
- Address any minor typos in the comments to maintain a professional and polished codebase.
- Verify that the workflow behaves as expected with the new triggers, especially in edge cases where a pull request might change states rapidly. This could help catch any potential issues before they affect the repository's operation.
There was a problem hiding this comment.
Sourcery Review:
PR Type: Enhancement
Summary of PR: This PR updates the GitHub Actions workflow to trigger the Sourcery code review on additional events: when a pull request is opened (provided it's not a draft), when a draft pull request is marked as ready for review, and when the sourcery-review label is added to a pull request.
General PR suggestions
- Ensure that the logical conditions in the workflow file are correctly ordered to prevent any unintended behavior. Specifically, use parentheses to group conditions properly when mixing 'AND' and 'OR' operators.
- Add explanatory comments next to new trigger conditions for clarity and consistency with the existing documentation in the workflow file.
- Review the workflow to ensure it only runs on relevant labeled events to avoid unnecessary runs, which could save on build minutes and reduce noise.
- Correct any typos in the comments to maintain professionalism and clarity in the documentation.
- Consider the overall readability and maintainability of the workflow file, ensuring that it is easy for future contributors to understand and modify the triggers as needed.
No description provided.